Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(tikv): bump tikv build image tag #527

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jan 8, 2025

The new tag image is built with dwz tool installed.

The new tag image is built with `dwz` tool installed.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from purelind January 8, 2025 11:11
Copy link

ti-chi-bot bot commented Jan 8, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the key change is to update the tikv build image tag to a newer version that has dwz tool installed. This is reflected in the diff by changing the value of image for the builders section in packages.yaml.tmpl.

There don't seem to be any potential problems with this pull request, as it seems to be a straightforward update to the build image tag.

As for fixing suggestions, it would be helpful to include a brief explanation in the pull request description about what dwz tool is and why it's beneficial to have it installed in the build image. This can help other contributors understand the reasoning behind the change and potentially avoid confusion or questions in the future.

Additionally, it might be useful to update any relevant documentation or README files to reflect this change, if applicable.

@ti-chi-bot ti-chi-bot bot added the size/XS label Jan 8, 2025
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jan 8, 2025

/approve

Ref tikv/tikv#18035

Copy link

ti-chi-bot bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 8, 2025
@ti-chi-bot ti-chi-bot bot merged commit 310df2a into main Jan 8, 2025
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/update-tikv-builder-with-dwz-tool-installed branch January 8, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant