Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pingcap/ticdc): support publish artifacts for the repo's trunk branch #528

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jan 9, 2025

Artifacts:

  • tiup package cdc nightly version will be published to tiup mirror from this repo(switched from tiflow repo).
  • container image pingcap/ticdc:master in docker hub will be published from this repo.

@ti-chi-bot ti-chi-bot bot requested a review from purelind January 9, 2025 08:24
Copy link

ti-chi-bot bot commented Jan 9, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and the diff, it seems that the changes in this PR introduce support for publishing artifacts for the pingcap/ticdc repository's trunk branch. Specifically, the changes include adding support for building and publishing container images and packages for the community edition of ticdc.

One potential issue with the changes is that the ticdc section in the packages/packages.yaml.tmpl file doesn't have any information about building container images. This could lead to confusion or errors when trying to build and publish container images for ticdc.

To fix this, it would be helpful to add a section to the ticdc part of the packages/packages.yaml.tmpl file that specifies how to build and publish container images for ticdc.

Another potential issue is that the PR description is empty, which makes it difficult to understand the reasoning behind the changes. It would be helpful to add a brief description of the changes and why they are necessary.

To fix this, it would be great to add a brief description to the PR description to provide some context about the changes and what problem they are solving.

@ti-chi-bot ti-chi-bot bot added the size/L label Jan 9, 2025
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jan 9, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and the diff, it seems that the changes in this PR introduce support for publishing artifacts for the pingcap/ticdc repository's trunk branch. Specifically, the changes include adding support for building and publishing container images and packages for the community edition of ticdc.

One potential issue with the changes is that the ticdc section in the packages/packages.yaml.tmpl file doesn't have any information about building container images. This could lead to confusion or errors when trying to build and publish container images for ticdc.

To fix this, it would be helpful to add a section to the ticdc part of the packages/packages.yaml.tmpl file that specifies how to build and publish container images for ticdc.

Another potential issue is that the PR description is empty, which makes it difficult to understand the reasoning behind the changes. It would be helpful to add a brief description of the changes and why they are necessary.

To fix this, it would be great to add a brief description to the PR description to provide some context about the changes and what problem they are solving.

I have added the image section:

          - name: container image - cdc
            type: image
            artifactory:
              repo: "{{ .Release.registry }}/pingcap/ticdc/image"
            dockerfile: https://github.com/PingCAP-QE/artifacts/raw/main/dockerfiles/products/ticdc/Dockerfile
            files: # context files
              - { name: cdc, src: { path: bin/cdc } }

Copy link

ti-chi-bot bot commented Jan 9, 2025

@wlwilliamx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jan 9, 2025

/approve

Copy link

ti-chi-bot bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlwilliamx, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 9, 2025
@ti-chi-bot ti-chi-bot bot merged commit 229d393 into main Jan 9, 2025
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/add-cdc-repo branch January 9, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants