-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pingcap/ticdc): support publish artifacts for the repo's trunk branch #528
Conversation
…t repo on trunk branch Signed-off-by: wuhuizuo <[email protected]>
Based on the PR title and the diff, it seems that the changes in this PR introduce support for publishing artifacts for the One potential issue with the changes is that the To fix this, it would be helpful to add a section to the Another potential issue is that the PR description is empty, which makes it difficult to understand the reasoning behind the changes. It would be helpful to add a brief description of the changes and why they are necessary. To fix this, it would be great to add a brief description to the PR description to provide some context about the changes and what problem they are solving. |
I have added the image section: - name: container image - cdc
type: image
artifactory:
repo: "{{ .Release.registry }}/pingcap/ticdc/image"
dockerfile: https://github.com/PingCAP-QE/artifacts/raw/main/dockerfiles/products/ticdc/Dockerfile
files: # context files
- { name: cdc, src: { path: bin/cdc } } |
@wlwilliamx: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlwilliamx, wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Artifacts:
cdc
nightly version will be published to tiup mirror from this repo(switched from tiflow repo).pingcap/ticdc:master
in docker hub will be published from this repo.