-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(apps/prod/tekton/configs): use delicated publisher to fast tiup publishing #1298
Conversation
wuhuizuo
commented
Oct 28, 2024
- make fast and stable for staging nightly ad RC tiup pkg publishing
- make fast and stable for GA tiup pkg publishing.
- rate limit for nightly is not implemented yet, so we still use old way for prod nightly publising.
Based on the pull request title and description, it seems like the changes made are related to optimizing the publishing of TIUP packages for different environments. The new implementation uses a dedicated publisher to speed up the publishing process for staging, nightly, and GA packages. Looking at the diff, the main changes are the addition of a new task However, there are a few potential issues that need to be addressed:
To address these issues, I suggest the following:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…iup publishing Signed-off-by: wuhuizuo <[email protected]>
6f21dc2
to
d887fce
Compare
This pull request aims to refactor the One potential problem is that the rate limiting for nightly publishing is not yet implemented, which could cause issues with the stability and speed of publishing. To fix this issue, the team could look into implementing rate limiting for nightly publishing to ensure that it is stable and efficient. Additionally, they could consider adding more tests to ensure that the changes made in this pull request do not cause any issues. Overall, the changes made in this pull request seem to be beneficial for the stability and speed of publishing TIUP packages. |