Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update boskos-resources.yaml" #1320

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Nov 8, 2024

Reverts #1306

@ti-chi-bot ti-chi-bot bot requested a review from purelind November 8, 2024 08:47
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Nov 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, this PR is reverting a previous change made in Pull Request #1306. However, looking at the diff, it appears that the only change being reverted is the addition of a commented-out section related to MacMachineConfig for darwin-arm64-1.

There doesn't seem to be any potential problems with this reversion, as it is a simple removal of commented-out code. However, it's unclear why this change is being reverted in the first place, as the PR description doesn't provide any context.

If the original change was made in error and there is no longer a need for the commented-out code, then this reversion is appropriate. However, if there is still a need for that code and the original change was made intentionally, then this reversion should be reconsidered.

As for fixing suggestions, if the reversion is indeed necessary, then the current diff looks good and can be merged as is. If there is any further context or explanation for the reversion, it would be helpful to add it to the PR description for future reference.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Nov 8, 2024

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 99760c0 into main Nov 8, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the revert-1306-wuhuizuo-patch-2 branch November 8, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant