Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt(apps/gcp/prow/release): try to fastup tide update speed #1321

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Nov 8, 2024

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from purelind November 8, 2024 12:26
@ti-chi-bot ti-chi-bot bot added area/apps env/GCP will deploy on GCP cluster labels Nov 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the key change is adding additional arguments to the Tide deployment in the release.yaml file, with the aim of increasing the speed of updates. Specifically, the --sync-hourly-tokens and --status-hourly-tokens values have been increased from their default values of 800 and 400, respectively, to 1200 and 600.

Potential problems with this change could include increased load on the system, leading to potential performance issues or resource constraints. Additionally, it is possible that increasing the token limits may cause issues with authentication or authorization, depending on how these tokens are used.

To address these potential issues, it may be helpful to test the changes in a staging environment before deploying to production. It may also be useful to monitor system performance after the update and adjust resource limits as needed.

Overall, the change seems reasonable and the suggested values for the token limits appear to be within a reasonable range.

@ti-chi-bot ti-chi-bot bot added the size/XS label Nov 8, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit 13f3ef7 into main Nov 12, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/speedup-tide-syncing branch November 12, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant