Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/gcp/prow): reduce the frequent of scanning all PRs for needs-rebase plugin #1325

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

wuhuizuo
Copy link
Collaborator

reduce the frequent for scanning all PRs.

reduce the frequent for scanning all PRs.
@ti-chi-bot ti-chi-bot bot requested a review from purelind November 12, 2024 04:51
@ti-chi-bot ti-chi-bot bot added area/apps env/GCP will deploy on GCP cluster labels Nov 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 12, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the key change is reducing the frequency of scanning all PRs by changing the --update-period flag from 5m to 24h in the release.yaml file. This change is intended to improve the performance of the needs-rebase plugin.

There don't seem to be any potential problems with this change. However, it's important to keep in mind that reducing the scanning frequency may impact the responsiveness of the needs-rebase plugin. If PRs require rebasing more frequently than once per day, this change may cause delays in identifying PRs that need attention.

To address this, I would suggest adding a comment to the pull request asking if any performance testing has been done to ensure that the needs-rebase plugin is still responsive with this change. Additionally, it may be helpful to include a note in the release.yaml file about the potential impact of changing the --update-period flag.

Overall, this seems like a straightforward change that should improve the performance of the needs-rebase plugin without causing any major issues.

@ti-chi-bot ti-chi-bot bot added the size/XS label Nov 12, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3bd1347 into main Nov 12, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the wuhuizuo-patch-2 branch November 12, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant