-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(prod/jenkins): add secret for ks3util config #1353
chore(prod/jenkins): add secret for ks3util config #1353
Conversation
Based on the PR title and description, it seems that the author is adding a secret for ks3util configuration in the production Jenkins environment. The changes are made in the The changes add a new secret for It seems that the changes are straightforward and there are no obvious problems with the code. However, there are a few suggestions that can be made to improve the PR:
Overall, the changes seem fine, and the suggestions are minor. The PR can be approved and merged into the production environment after addressing the suggestions. |
/hold Effective when there is no pipelines activity. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Add secret for ks3util config.
Already test in jenkins beta: #1352