Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prod/jenkins): correct read file credentials #1360

Conversation

purelind
Copy link
Contributor

@purelind purelind commented Dec 1, 2024

use base64 to correct read file credentials.

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo December 1, 2024 07:44
@ti-chi-bot ti-chi-bot bot added the area/apps label Dec 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from purelind, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the env/prod will deploy on the main product cluster label Dec 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 1, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the key change is that the secretBytes field in the values-JCasC.yaml file for the ks3util-config has been updated to use the base64 function to correctly read the file credentials.

One potential problem that I see is that it's not clear whether the ks3util-conf value is already base64 encoded or not. If it's already encoded, then applying the base64 function again will result in an invalid encoding which may cause issues.

To fix this, the contributor should ensure that the ks3util-config value is not already base64 encoded before applying the base64 function. They could do this by decoding the value first (if it is already encoded) before applying the base64 function.

Another suggestion would be to provide more context in the pull request description to explain why this change is necessary and what problems it solves. This will help reviewers understand the reasoning behind the change and ensure that it aligns with the project's goals.

@purelind purelind merged commit 5fc091c into PingCAP-QE:main Dec 1, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot added the size/XS label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant