Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps/prod/tekton/configs): update pipeline for artifacts repo #676

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Sep 2, 2023

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind September 2, 2023 17:04
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Pull Request Review

The pull request is titled "chore(apps/prod/tekton/configs): update pipeline for artifacts repo". The pull request includes changes to the following files:

  • apps/prod/tekton/configs/pipelines/kustomization.yaml
  • apps/prod/tekton/configs/pipelines/pull-pingcap-qe-artifacts-build-image.yaml
  • apps/prod/tekton/configs/triggers/event-listeners/event-listener.yaml
  • apps/prod/tekton/configs/triggers/templates/kustomization.yaml
  • apps/prod/tekton/configs/triggers/templates/pull-pingcap-qe-artifacts.yaml
  • apps/prod/tekton/configs/triggers/triggers/kustomization.yaml
  • apps/prod/tekton/configs/triggers/triggers/pull-pingcap-qe-artifacts.yaml

The changes rename pipeline1.yaml to pull-pingcap-qe-artifacts-build-image.yaml and update the corresponding references to it in the other files. The changes also update the name of the trigger and the template.

Potential Problems:

Based on the review of the pull request, I did not find any potential problems in the changes made.

Fixing Suggestions:

No fixing suggestions needed as the changes appear to be straightforward and the code modifications look good.

@ti-chi-bot ti-chi-bot bot added the size/M label Sep 2, 2023
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Sep 2, 2023

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit 488cb42 into main Sep 2, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/tekton-filter-on-repo branch September 2, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant