Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infrastructure): add nfs PVC provisioner #692

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 29, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
This pull request adds an nfs PVC provisioner to the infrastructure and includes changes to the kustomization.yaml files in both the _base and prod directories.

One potential problem is that there is no explanation for why this change is being made or what problem it solves. Additionally, there are no tests included to ensure that the new provisioner is working as expected.

A suggestion for fixing this would be to include a brief explanation in the pull request description of why this change is being made and how it will benefit the project. Additionally, creating tests to ensure that the provisioner is working as expected would be a good idea.

Lastly, it is important to ensure that the code is properly formatted and adheres to any established style guides.

@wuhuizuo
Copy link
Collaborator Author

/approve

@ti-chi-bot ti-chi-bot bot added the size/M label Sep 29, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 29, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4752739 into main Sep 29, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/prod-nfs-storageclass branch September 29, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant