Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps/prod): add cloudevents-server instance #693

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Oct 5, 2023

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind October 5, 2023 08:59
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 5, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
This pull request adds a cloudevents-server instance to the prod applications. It includes changes to helm-repo-ee-apps.yaml, kustomization.yaml, config-configmap.yaml, data-pvc.yaml, kustomization.yaml, and release.yaml.

One potential problem is that the storageClassName in data-pvc.yaml is hardcoded to ceph-block, which may not be available in all environments. A possible solution would be to make this configurable via a parameter or an environment variable.

Another improvement suggestion would be to add some more details to the PR description, such as the reasoning behind adding this instance and any testing or validation that has been done.

Overall, the changes seem reasonable and well-organized.

@ti-chi-bot ti-chi-bot bot added the size/L label Oct 5, 2023
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Oct 5, 2023

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 5, 2023
@ti-chi-bot ti-chi-bot bot merged commit 138c79d into main Oct 5, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/cloudevents-server branch October 5, 2023 09:07
wuhuizuo added a commit that referenced this pull request Oct 5, 2023
wuhuizuo added a commit that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant