Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

基于rack重新实现webhooks验证方法 #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mythhsy
Copy link

@mythhsy mythhsy commented Apr 27, 2017

  1. @wjp2013 老铁按照SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed #11 里提到的,用基于rack的代码调整了一下webhook方法,发了这个PR,你有时间可以帮看下,THX^-^.

  2. @samurai00 希望review一下,我觉得用sinatra框架的人还是不少的,gem官方支持下应该很好,至少我自己就在用,🙂.

mythhsy and others added 2 commits April 27, 2017 12:14
2. 稍微调整了下部分代码,尽量遵循ruby-style-guide.
3. 同步更新README文档.
sorry,代码提交的问题
@GiaoGiaoCat
Copy link
Contributor

GiaoGiaoCat commented May 2, 2017

如果 #11 的问题没解决,我应该是不会再更新 gem 的版本。
PS: 目测代码没毛病

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants