PET-16 Go coverage only in cmd and pkg directories #57
Conversation
| @@ -54,7 +58,7 @@ runs: | |||
|
|
|||
| - name: Run tests | |||
| shell: bash | |||
| run: go test ./... -v -coverpkg=./... -coverprofile cover.out | |||
| run: go test ./cmd/... ./pkg/... -v -coverpkg=./cmd/...,./pkg/... -coverprofile cover.out | |||
There was a problem hiding this comment.
What if some modules would have an internal directory as well?
There was a problem hiding this comment.
What purpose does this change have?
There was a problem hiding this comment.
@Decard6 https://github.com/PiwikPRO/PPMS-DomainResolver/pull/60/files
@radekska I think that we should introduce a global convention of putting the go project files only in pkg and cmd directory in order for it to work. If you plan to use internal packages, there's no problem in putting them under pkg/internal i suppose.
There was a problem hiding this comment.
@radekska Hmm, now i've read your link. Should we add the internal package to the flags as well?
There was a problem hiding this comment.
@glothriel not sure how many modules actually use a separate internal package, though making test and coverage directories configurable would be a plus
There was a problem hiding this comment.
I'd say so, we probably want to adjust to go standards.
There was a problem hiding this comment.
I'm going to get back to this on next pet project friday
New go version, parametrized.