-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded dependencies to support Angular versions higher than 13.x. And also recreated package-lock.json
in the NodeJS API to work with versions starting from v16
#11
Conversation
… also recreated `package-lock.json` in the NodeJS API to work with versions starting from v16
Can somebody please approve this? Its urgently needed |
Update: If i use this fork, i get a malware warning?! installed with: |
@RGunning ? Maybe u r available? |
package-lock.json
in the NodeJS API to work with versions starting from v16 package-lock.json
in the NodeJS API to work with versions starting from v16
Hi @andrii-lundiak, I have checked your solution and it seems wrong. Maybe I am thinking wrongly what you would like to fix, namely the package you are updating relates to a project that bundles the demo application together with the ngx-piwik-pro package. Actually, my PR, which is already available on NPM, should suffice to solve the problem. If you can, please test it in your case. |
@danieltwork Actually, you are right, I did it wrong (I WILL CLOSE THIS PR as soon as I solve my problem). But.. Look.. When I And as u see it installs https://www.npmjs.com/package/@piwikpro/ngx-piwik-pro?activeTab=versions But this https://github.com/PiwikPRO/ngx-piwik-pro/blob/master/projects/ngx-piwik-pro/package.json refers to |
awesome @danieltwork! |
@danieltwork I would recommend to sync version here also (
|
I once DO CONFIRM, that after installing Thanks @danieltwork I do close this MY PR, but remember about suggestions in previous comments. |
@andrii-lundiak thanks! |
First it's about issue #9 and that is my try to upgrade code to support work with latest version of Angular.
Here is example when I install the package for ng 14.x project:
And sure thing we can suppress it, but it's better to avoid.
npm outdated
shows/hints of how is going on with versions.Plus, also
package-lock.json
has been recreated within NodeJS version16.2.1
to support all future NodeJS /npm API support for the lock file.npm test
:npm run test:dev
Here is result of GitHub Actions executed from my experimental branch on my fork:
PS. Having such
package.json
as suggested by this PR we can see on when it's installed on custom project there is NO warning about versions mismatch ANYMORE:But that is NOT concern of this PR. Maybe I will create separate, or maybe maintainer of package will do.