Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded dependencies to support Angular versions higher than 13.x. And also recreated package-lock.json in the NodeJS API to work with versions starting from v16 #11

Closed
wants to merge 1 commit into from

Conversation

andrii-lundiak
Copy link

@andrii-lundiak andrii-lundiak commented Dec 13, 2022

First it's about issue #9 and that is my try to upgrade code to support work with latest version of Angular.

Here is example when I install the package for ng 14.x project:
image

And sure thing we can suppress it, but it's better to avoid.

npm outdated shows/hints of how is going on with versions.
cropped

Plus, also package-lock.json has been recreated within NodeJS version 16.2.1 to support all future NodeJS /npm API support for the lock file.

npm test:

cropped2

npm run test:dev
image

Here is result of GitHub Actions executed from my experimental branch on my fork:
image

image

PS. Having such package.json as suggested by this PR we can see on when it's installed on custom project there is NO warning about versions mismatch ANYMORE:

npm ci

npm WARN deprecated @npmcli/[email protected]: This functionality has been moved to @npmcli/fs
npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated [email protected]: Please update to latest patch version to fix memory leak https://github.com/isaacs/node-lru-cache/issues/227
npm WARN deprecated [email protected]: Please use @jridgewell/sourcemap-codec instead
npm WARN deprecated [email protected]: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.

added 914 packages, and audited 915 packages in 15s

100 packages are looking for funding
  run `npm fund` for details

11 vulnerabilities (1 low, 2 moderate, 5 high, 3 critical)

To address all issues, run:
  npm audit fix

But that is NOT concern of this PR. Maybe I will create separate, or maybe maintainer of package will do.

… also recreated `package-lock.json` in the NodeJS API to work with versions starting from v16
@MoFranky
Copy link

Can somebody please approve this? Its urgently needed

@andrii-lundiak
Copy link
Author

@danieltwork ?

@koesper
Copy link

koesper commented Feb 22, 2023

Update:
Apologies, this does not seem to be something specific to this branch.
I'll open a regular ticket on the repo.

If i use this fork, i get a malware warning?!
piwik-pro-angular-tracking * Severity: critical Malware in piwik-pro-angular-tracking - https://github.com/advisories/GHSA-93jq-pwrf-g6h6

installed with:
npm i @piwikpro/ngx-piwik-pro git://github.com/andrii-lundiak/ngx-piwik-pro.git#e06cd52054448646eae85550b576b56c21595ac3

@andrii-lundiak
Copy link
Author

@RGunning ? Maybe u r available?

@andrii-lundiak andrii-lundiak changed the title Upgraded dependencies to support Angular versions more than 13.x. And also recreated package-lock.json in the NodeJS API to work with versions starting from v16 Upgraded dependencies to support Angular versions higher than 13.x. And also recreated package-lock.json in the NodeJS API to work with versions starting from v16 Feb 22, 2023
@danieltwork
Copy link
Contributor

Hi @andrii-lundiak, I have checked your solution and it seems wrong. Maybe I am thinking wrongly what you would like to fix, namely the package you are updating relates to a project that bundles the demo application together with the ngx-piwik-pro package. Actually, my PR, which is already available on NPM, should suffice to solve the problem. If you can, please test it in your case.

@andrii-lundiak
Copy link
Author

andrii-lundiak commented Feb 22, 2023

@danieltwork Actually, you are right, I did it wrong (I WILL CLOSE THIS PR as soon as I solve my problem). But..

Look..

When I npm install @piwikpro/ngx-piwik-pro@latest I then got the package installed from NPM registry:

image

And as u see it installs 1.0.1 version.
Which was THE LATEST from registry:

https://www.npmjs.com/package/@piwikpro/ngx-piwik-pro?activeTab=versions
Until 20 minutes ago there was publish somehow to 1.0.2 - was it u?

But this https://github.com/PiwikPRO/ngx-piwik-pro/blob/master/projects/ngx-piwik-pro/package.json refers to 0.0.5 version.

@koesper
Copy link

koesper commented Feb 22, 2023

awesome @danieltwork!
I now see v1.0.2 on npm and that installed without a hitch on my angular 15 project.
Now that you mention that this repo is a wrapper around the npm project, i finally understand where that name piwik-pro-angular-tracking came from, and why that didnt match with wat we see on npm.
Perhaps you can rename it in this repo as wel, for instance to @piwikpro/ngx-piwik-pro-project or something that signifies it is the parent of the npm package?

@andrii-lundiak
Copy link
Author

andrii-lundiak commented Feb 22, 2023

@danieltwork I would recommend to sync version here also (0.0.5 => 1.0.2 or 1.0.3):
https://github.com/PiwikPRO/ngx-piwik-pro/blob/master/projects/ngx-piwik-pro/package.json#L3

+ to recommendation from @koesper

@andrii-lundiak
Copy link
Author

I once DO CONFIRM, that after installing 1.0.2 version, I can use my Angular v14 project setup OK (meaning I don't need --force while installing ANY packages).

Thanks @danieltwork I do close this MY PR, but remember about suggestions in previous comments.

@danieltwork
Copy link
Contributor

@andrii-lundiak thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants