Feature/ppi 976 new ecommerce methods #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysy-vlc
force-pushed
the
feature/PPI-976-new-ecommerce-methods
branch
from
b5e2b7b to
83522e5
Compare
waszkowski
suggested changes
Dec 15, 2023
|
|
||
| type Props = { | ||
| product: Product | null | ||
| open: boolean |
There was a problem hiding this comment.
Maybe isOpen instead of open? I think that verbs should describe functions as in the next line "close".
example/src/pages/CustomEvent.tsx
Outdated
| import Paper from '@mui/material/Paper' | ||
|
|
||
| const CustomEventPage: FunctionComponent = () => { | ||
| const [finish, setFinish] = React.useState(false) |
There was a problem hiding this comment.
Why are you importing "useEffect" but "useState" don't?
| ]); | ||
| export function updateEcommerceCart( | ||
| products: Product[], | ||
| grandTotal: number | string |
There was a problem hiding this comment.
What do you think about reusing PaymentInformation and doing it this way PaymentInformation['grandTotal']
package.json
Outdated
| @@ -20,43 +20,43 @@ | |||
| "test:lint": "eslint .", | |||
| "test:unit": "cross-env CI=1 react-scripts test --env=jsdom", | |||
| "test:watch": "react-scripts test --env=jsdom", | |||
| "predeploy": "cd example && yarn install && yarn run build", | |||
| "deploy": "gh-pages -d example/build" | |||
| "predeploy": "cd example-old && yarn install && yarn run build", | |||
There was a problem hiding this comment.
Why wasn't the old example deleted? And what about the new example?
waszkowski
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.