Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ecommerce customDimensions #27

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix: ecommerce customDimensions #27

merged 1 commit into from
Jan 30, 2024

Conversation

auto200
Copy link
Contributor

@auto200 auto200 commented Jan 29, 2024

We have to send only dimension id ex. 1 instead of full name dimension1 when supplying ecommerce customDimensions. Otherwise we see errors in the debugger
image

also export Product and PaymentInformation types from lib

@auto200
fix: ecommerce customDimensions
c1be33a 
export Product and PaymentInformation types from lib
@auto200 auto200 merged commit c8b47cc into master Jan 30, 2024
4 checks passed
@auto200 auto200 deleted the fix/ecommerce-custom-dimensions branch January 30, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysy-vlc lysy-vlc lysy-vlc approved these changes

@waszkowski waszkowski Awaiting requested review from waszkowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@auto200 @lysy-vlc