Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving 2 issues on generateEventName function #9

Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
24271eb
Solving 2 issues :
OphelieMicoine Nov 11, 2024
f285f15
Solving 2 issues :
OphelieMicoine Nov 11, 2024
813291a
Merge remote-tracking branch 'origin/solving-issues-on-generateEventN…
OphelieMicoine Nov 22, 2024
ad2026c
Solving 2 issues :
OphelieMicoine Nov 22, 2024
1efd595
Fixed event recognition pipeline
abartczakpiwik Nov 25, 2024
b268e8e
Update metadata
abartczakpiwik Nov 25, 2024
77fba3c
Readjusted README and fixed commit signing
abartczakpiwik Jan 2, 2025
f0c9239
Update metadata
abartczakpiwik Jan 2, 2025
2105380
Add support for ppas.js loading
sahava Sep 25, 2024
fdf93a9
Update metadata
sahava Sep 25, 2024
bacea5e
Add support for piwik.php endpoint
abartczakpiwik Oct 29, 2024
0887afa
Update metadata.yaml
abartczakpiwik Oct 29, 2024
50e015e
Solving 2 issues :
OphelieMicoine Nov 11, 2024
23330df
Signed Solving 2 issues :
OphelieMicoine Nov 11, 2024
ecf66a9
Signed Solving 2 issues :
OphelieMicoine Nov 22, 2024
7fb2de5
Signed Solving 2 issues :
OphelieMicoine Jan 2, 2025
774f1a4
Fixed event recognition pipeline
abartczakpiwik Nov 25, 2024
182dd1a
Update metadata
abartczakpiwik Nov 25, 2024
f34b5bd
Readjusted README and fixed commit signing
abartczakpiwik Jan 2, 2025
3a580d1
Update metadata
abartczakpiwik Jan 2, 2025
d2e3949
Merge branch 'master' into solving-issues-on-generateEventName-function
OphelieMicoine Jan 2, 2025
3609500
Merge branch 'solving-issues-on-generateEventName-function' of https:…
abartczakpiwik Jan 8, 2025
2bea683
Update metadata
abartczakpiwik Jan 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions template.tpl
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
___TERMS_OF_SERVICE___
OphelieMicoine marked this conversation as resolved.
Show resolved Hide resolved

By creating or modifying this file you agree to Google Tag Manager's Community
Template Gallery Developer Terms of Service available at
https://developers.google.com/tag-manager/gallery-tos (or such other URL as
Google may provide), as modified from time to time.


___INFO___
___INFO___

{
"type": "CLIENT",
Expand Down Expand Up @@ -236,6 +228,10 @@ const generateEventName = (requestData) => {
return requestData;
} else if (requestData.ping) {
requestData.event_name = 'ping';
} else if (requestData.c_i) {
requestData.event_name = 'content_interaction';
} else if (requestData.c_n) {
requestData.event_name = 'content_impression';
} else if (requestData.e_t) {
requestData.event_name = requestData.e_t;
} else if (requestData.e_c) {
Expand All @@ -246,11 +242,11 @@ const generateEventName = (requestData) => {
requestData.event_name = 'click';
} else if (requestData.download) {
requestData.event_name = 'file_download';
} else if (requestData.action_name) {
requestData.event_name = 'page_view';
} else if (requestData.idgoal) {
abartczakpiwik marked this conversation as resolved.
Show resolved Hide resolved
requestData.event_name = 'goal_conversion';
} else {
} else if (requestData.action_name) {
requestData.event_name = 'page_view';
} else {
requestData.event_name = DEFAULT_EVENT_NAME;
}
return requestData;
Expand Down