PCH Location did not take into account the build configuration #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multi-config generators (like MSVC).
|
Filed as internal issue #USD-8714 |
|
I am getting a compiler error when trying to build USD v24.08 on Windows using VS2022 that is due to this change. When I revert this change it compiles without error. |
|
At an airport about to go on PTO. Been a while since that change so I suspect a change in context/environment. If I get a chance, will see if I can pull it down and test Otherwise, it will be three weeks before I am back home.
…On Thu, Aug 15, 2024 at 12:15, Sean Donnelly ***@***.***(mailto:On Thu, Aug 15, 2024 at 12:15, Sean Donnelly <<a href=)> wrote:
I am getting a compiler error when trying to build USD v24.08 on Windows using VS2022 that is due to this change. When I revert this change it compiles without error.
[316/4275] Building CXX object pxr\base\arch\CMakeFiles\arch.dir\pch.cpp.obj
FAILED: pxr/base/arch/CMakeFiles/arch.dir/pch.cpp.obj
C:\PROGRA~1\MIB055~1\2022\PROFES~1\VC\Tools\MSVC\1440~1.338\bin\Hostx64\x64\cl.exe /nologo /TP -DARCH_EXPORTS=1 -DBOOST_ALL_DYN_LINK -DBOOST_ALL_NO_LIB -DBOOST_PYTHON_NO_PY_SIGNATURES -DGLX_GLXEXT_PROTOTYPES -DGL_GLEXT_PROTOTYPES -DMFB_ALT_PACKAGE_NAME=arch -DMFB_PACKAGE_MODULE=Arch -DMFB_PACKAGE_NAME=arch -DNOMINMAX -DOPENEXR_DLL -DPXR_BUILD_LOCATION=usd -DPXR_GL_SUPPORT_ENABLED -DPXR_MATERIALX_SUPPORT_ENABLED -DPXR_OIIO_PLUGIN_ENABLED -DPXR_PLUGIN_BUILD_LOCATION=../plugin/usd -DTBB_SUPPRESS_DEPRECATED_MESSAGES=1 -DWIN32_LEAN_AND_MEAN -DYY_NO_UNISTD_H -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS -Darch_EXPORTS -IT:\ecg-usd-build\v24.08\build\RelWithDebInfo\build\usd\include /EHsc /Zc:rvalueCast /Zc:strictStrings /Zc:inline- /W3 /bigobj /Zi /MP /Gm- /wd4003 /wd4244 /wd4305 /wd4267 /wd4506 /wd4091 /wd4273 /wd4180 /wd4334 /Zm150 /MD /Zi /O2 /Ob1 /DNDEBUG -std:c++17 /Yc"pxr/base/arch/pch.h" /FI"pxr/base/arch/pch.h" /Fp"T:/ecg-usd-build/v24.08/build/RelWithDebInfo/build/usd/include/pxr/base/arch/RelWithDebInfo/pch.pch" /showIncludes /Fopxr\base\arch\CMakeFiles\arch.dir\pch.cpp.obj /Fdpxr\base\arch\CMakeFiles\arch.dir\ /FS -c T:\ecg-usd-build\v24.08\build\RelWithDebInfo\build\usd\pxr\base\arch\pch.cpp
c1xx: fatal error C1083: Cannot open compiler intermediate file: 'T:/ecg-usd-build/v24.08/build/RelWithDebInfo/build/usd/include/pxr/base/arch/RelWithDebInfo/pch.pch': No such file or directory
—
Reply to this email directly, [view it on GitHub](#2698 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAJOTL6Q4R5JITGQGZ3JP2TZRT43NAVCNFSM6AAAAAA42SCBW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJSGAZDKNBWGA).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
No rush. I have reverted the change locally and thus was able to build 24.08. Enjoy your vacation. Thanks, |
|
I'm seeing the same Windows compilation failure in both 24.08 and 24.11. I note that the GitHub actions in this repo have PCHs disabled, but there's not enough information in the commit message to tell if this was intentional with the change in this PR. https://github.com/PixarAnimationStudios/OpenUSD/blob/release/.github/workflows/buildusd.yml#L177 Can I enquire whether any further work is intended here? Or perhaps, is there an intent for Windows source-build users to disable PCHs as per the CI? Thanks, |
|
Just want to echo that I've seen this too on Windows, but haven't dug into this deeply. I do think that PCH is intended for Windows so I'd recommend filing a github issue with what you're seeing. |
|
Agree with the post an issue response. Will also take a look at it on Monday. Lost track of the request due to PTO.
…On Thu, Nov 7, 2024 at 06:19, nvmkuruc ***@***.***(mailto:On Thu, Nov 7, 2024 at 06:19, nvmkuruc <<a href=)> wrote:
Just want to echo that I've seen this too on Windows, but haven't dug into this deeply.
I do think that PCH is intended for Windows so I'd recommend filing a github issue with what you're seeing.
—
Reply to this email directly, [view it on GitHub](#2698 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAJOTL4GL73QTHSBU4W7NFDZ7NZFNAVCNFSM6AAAAAA42SCBW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRSGM2TIOJRGQ).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Done |
|
Sorry for taking so long to get back to you. The project that was using OpenUSD, I haven't touched for over a year. Had some code rot to deal with and fix. Got it running, and then rebased my original changes. They definitely didn't take all of the fixes I had in PRs a year ago, so not surprised you are running into issues. I'll see about putting together some more PRs again (or reviving the old ones) and see if there is any interest.
…On Thursday, November 7th, 2024 at 8:31 AM, Mark Final ***@***.***> wrote:
Done
[#3408](#3408)
—
Reply to this email directly, [view it on GitHub](#2698 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAJOTLZ7EO5OTBCWBXQQPTTZ7OIW3AVCNFSM6AAAAAA42SCBW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRSGY4DQMZQGQ).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Fixes Issue(s)