Add caching, network handler improvements, and performance improvements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved Network connection handling via a connection read timeout, with exception handling Improved API Response Handler - BufferedReader now reads the entire response string and checks whether it is null before assigning it to the 'timezone' variable
…timezone via UUID
When the API call fails, added a new BukkitRunnable that will be scheduled to run after the retryDelay. It will retry adding the timezone to the map after the delay instead of adding it immediately. This way, we prevent overloading the API
getTimeZone now uses a new thread instead of a BukkitRunnable to handle the API request
Integrated 'ConcurrentHashMap' in place of 'Hashmap' to ensure the expansion is thread-safe retryDelay was also migrated to a new 'getTimeZoneFromAPI' method, and appropriately initialized
I really need to sleep...
Implement cache expiration in DateManager Optimize cache structure in DateManager Return CompletableFuture in DateManager's getTimeZone Adapt LocalTimeExpansion to work with updated DateManager
…e efficiency Remove cache expiry checks from getTimeZone method Remove data removal from onLeave event handler Create a new scheduled task removeExpiredEntries to handle cache expiry and player data removal Update isCacheExpired method to remove players from the timezones map when cache expires Add a check in removeExpiredEntries to skip non-UUID keys in the cache Remove unnecessary onLeave event handler and Listener implementation
iGabyTM
requested changes
Jul 12, 2023
`Shutdown` method to shut down the executor service on `clear()` Fixed `getTimeZone` method to be non-blocking Removed premature return of `CompletableFuture`
iGabyTM
requested changes
Jul 14, 2023
|
Could support be added for using an API key? People on shared hosts may not be able to use this regardless if other people on the same machine are making API calls. See: #3 |
iGabyTM
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes reduce API calls by caching a players timezone for a determinate period of time (1 day) and similarly, local-time placeholders are much more consistent with a retryDelay being ran in the event that a players timezone is unable to be fetched due to API rate-limits.
This should functionally mitigate a common occurrence of the expansion being "unable to fetch a players timezone" due to excessive API calls resulting in a rate-limit. The expansion has also been made to be completely thread-safe