Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/recipes placeholders #37

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Jaimss
Copy link

@Jaimss Jaimss commented Oct 7, 2020

resolves #28

Questions:

  • how should an invalid namespaced key be handled? right now I return "invalid recipe", is that ok?
  • for listing recipes, it's really ugly and there's really no use case it seems. maybe it should be removed
  • IntelliJ changed around imports. is that ok?
  • Version change required?

@iGabyTM
Copy link
Member

iGabyTM commented Oct 4, 2021

@Jaimss do you think you could update this?

@Jaimss
Copy link
Author

Jaimss commented Oct 4, 2021

Yea I'll try to update it when I get a chance.

@Jaimss
Copy link
Author

Jaimss commented Oct 4, 2021

that should have it working still
i can test it again later if you want but it was just resolving a merge conflict so hopefully nothing broke lol

@Tanguygab Tanguygab mentioned this pull request Aug 27, 2023
iGabyTM added a commit that referenced this pull request Jun 24, 2024
@iGabyTM iGabyTM mentioned this pull request Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placeholder to check player recipe status
2 participants