Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple 2 argument yes/no version #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gabo6480
Copy link

@Gabo6480 Gabo6480 commented Jul 18, 2022

This version is a simplified version that just uses the <player/viewer> argument and the < permission > argument, returning 'yes' if they have the permission, or 'no' otherwise.

This version is a simplified version that just uses the <player/viewer> argument and the <permission> argument, returning 'yes' if they have the permission, or 'no' otherwise.
@Gabo6480 Gabo6480 mentioned this pull request Jul 18, 2022
Copy link

@Kqliber Kqliber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yes/no returns should be changed to use PlaceholderAPIPlugin.booleanTrue() and PlaceholderAPIPlugin.booleanFalse() so that users can define their desired outputs using the existing config options

Instead of static 'yes' 'no' strings as a result, it now uses PlaceholderAPIPlugin.booleanTrue() and PlaceholderAPIPlugin.booleanFalse().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants