2nd Order NAE Constraints #1036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dpanici
commented
May 24, 2024
•
dpanici
commented
- make tests for this
- write out the coefficients in a simpler form (see below)
- add some warning or error for when trying to fix lambda and using asym qsc NAE constraints, since the qsc lambda does not necessarily have zero FSA which can cause the linear constraint projection to error out
- adjust Rlmn Zlmn when shifting lambda on axis for asym
This reverts commit f63d321.
…h does not use same name)
f0uriest
requested changes
Jan 21, 2025
SebereX
requested changes
Jan 21, 2025
| + X1phic * dR0 * dX1phic / 2 / R0**2 | ||
| - X1phis * dR0 * dX1phis / 2 / R0**2 | ||
| + X1phic**2 * ddR0 / 4 / R0**2 | ||
| - X1phis**2 * ddR0 / 4 / R0**2 |
| Notes | ||
| ---- | ||
| follows eqns 30a and 30b in NAE2DESC document | ||
| """ |
There was a problem hiding this comment.
Do you have a test or something like that to check the correct implementation of these coefficients?
There was a problem hiding this comment.
None beyond testing a solve with them, I can make one to test at least like the symmetries of each one or something though.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.