Feature/add maintenance poller #8
Conversation
Co-authored-by: Allan Targino <[email protected]>
| // standBy = append(standBy, gs) | ||
|
|
||
| // kubectl delete gameserver x -n default | ||
| err = n.clientset.RESTClient().Delete().AbsPath(apiGroup).Resource("gameservers").Namespace("default").Name(gs.Name).Do(ctx).Error() |
There was a problem hiding this comment.
what if the GameServers are on a different namespace?
| } | ||
|
|
||
| var gameServers mpsv1alpha1.GameServerList | ||
| err = n.clientset.RESTClient().Get().AbsPath(apiGroup).Resource("gameservers").Namespace("default").Do(ctx).Into(&gameServers) |
There was a problem hiding this comment.
Sorry, I know we talked about it but now that I see it, any chance we can replace the REST client with the generated libraries? You can see some of the code on the Thundernetes end to end tests on how to do that https://github.com/PlayFab/thundernetes/tree/main/cmd/e2e
This will allow for more consistency throughout the project.
Appreciated and apologies for the inconvenience!
There was a problem hiding this comment.
Plus, you will be able to access GameServer CRs in any namespace (related to another comment). Thank you!
| @@ -0,0 +1,36 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
This should run as a DaemonSet so it runs on every Node
| @@ -0,0 +1,13 @@ | |||
| # build stage | |||
There was a problem hiding this comment.
this Dockerfile format will work only on the main Thundernetes repo (where we set revisions etc.), not here unfortunately.
trocadilho
force-pushed
the
feature/add-maintenance-poller
branch
from
df78ffb to
34ead6e
Compare
|
hey @trocadilho, let us know if you want any help working with this PR! |
|
Also tagging @allantargino |
Experimental hackathon project representing a Thundernetes extension that when a maintenance event comes, it will:
Azure documentation on how to handle scheduled events