-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[search] Convert "test" to benchmark #4718
Comments
For anyone interested: benchmarks are added now, you can orient yourself at the existing benchmark(s). |
Added a new label for the new module. Should have done that before :) |
Hey, @mvieth can I work on this issue? |
@Zekrom-7780 Yes, you can work on this issue. Thank you! |
@mvieth @kunaltyagi I AM SOO SORRY, for reaching THIS late, but is this Still open? |
@Zekrom-7780 Sure, go ahead. |
@mvieth , I finished setting up the repo, and I saw like an entire test folder, and a benchmarks folder. Could you tell me on how to proceed with this? So sorry if this is a dumb question |
The goal is to convert this test: pcl/test/search/test_organized_index.cpp Line 359 in e8ed4be
to a proper benchmark (like the other benchmarks in the benchmarks folder). Notice how the test measures the time needed by setInputCloud and radiusSearch . The brute force search that is also performed in the test is pretty much useless and can be discarded.
|
Thanks for the explanation @mvieth , I have made a pull request, could you please look into it? Also, please could you tell me on how to get the build checks to pass, like which script do I have to run? Also, as mentioned in the pull request, Soo Sorry that I wasn't able to rebase the multiple commits into a single one |
Fixed by #5851 |
This "test" doesn't really belong here?
It seems to capture processing times, but don't print or use them / compare them?
Originally posted by @larshg in #4712 (comment)
The text was updated successfully, but these errors were encountered: