Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing unnecessary(?) return in _write_geotiff #277

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

gottacatchenall
Copy link
Member

@gottacatchenall gottacatchenall commented Sep 23, 2024

this fixes permission issues in docker that exist for unknown reasons re GEO-BON/bon-in-a-box-pipelines#170 (comment)

Copy link
Contributor

Documentation for this pull request: https://poisotlab.github.io/SpeciesDistributionToolkit.jl/previews/PR277/

@tpoisot
Copy link
Member

tpoisot commented Sep 24, 2024

Can you check what's going on with these changes?

@gottacatchenall
Copy link
Member Author

all the test pass locally for me with the write commented out, what part isn't working?

@jmlord
Copy link

jmlord commented Sep 24, 2024

all the test pass locally for me with the write commented out, what part isn't working?

It looks like it was cancelled more than failed:
image

@gottacatchenall
Copy link
Member Author

the SDMLayers CI item itself passes though

@tpoisot
Copy link
Member

tpoisot commented Sep 24, 2024

I dropped a full method that wasn't used anymore, and then I think this is ready to go. As soon as the tests pass, I'll tag the new release.

@tpoisot tpoisot merged commit b587ef3 into main Sep 24, 2024
16 checks passed
@tpoisot tpoisot deleted the mdc/io_permissions_bug branch September 24, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants