Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few gloves! #90

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

LesPirouettes
Copy link

@LesPirouettes LesPirouettes commented Mar 12, 2025

Description of changes

Adds some gloves. See changelog. Not yet encompassing all Polaris gloves, but I'm unfamiliar with Nebula's structure so I'm throwing this up to see if I've fucked everything up.

Why and what will this PR improve

Polaris parity.

Authorship

From Polaris' old repo, plus some sprites from Aurora.3.
Knuckledusters and fingerless gloves from Aurora.3. The rest from Polaris.

Changelog

🆑
add: Added mittens, fingerless gloves, and a basic implementation of knuckle dusters.
/:cl:

From Polaris' old repo, plus some sprites from Aurora.3
@LesPirouettes
Copy link
Author

Not sure how to make the fingerless and the dusters leave fingerprints. Looks like a change I'd have to put outside the modpack; thus upstream?

@Cerebulon
Copy link

Cerebulon commented Mar 12, 2025

Forensic gloves are already present in modules\clothing\gloves\miscellaneous.dm so there's no need to duplicate those. Surprisingly there's reference to fingerless gloves but they seem to have been removed at some point.
I'm not sure about fingerprints, there are already "gloves" that don't cover fingers (Rings) but I don't see any special forensics handling on those, the add_fingerprint proc seems to only check for items equipped in the glove slot which isn't all that indepth, I'll ask upstream to see if that's actually implemented.
Fingerprint-leaving is based on body_parts_covered so setting it to null should do the trick.

LesPirouettes and others added 3 commits March 12, 2025 23:36
Co-authored-by: Cerebulon <tanhindmarsh@yahoo.com>
Co-authored-by: Cerebulon <tanhindmarsh@yahoo.com>
@Cerebulon Cerebulon self-requested a review March 21, 2025 21:54

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't being referenced anymore and can probably be removed, it's only a world sprite anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants