Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address issue #873 #880

Closed
wants to merge 1 commit into from
Closed

address issue #873 #880

wants to merge 1 commit into from

Conversation

Nick-1979
Copy link
Member

@Nick-1979 Nick-1979 commented Oct 26, 2023

close #873

Summary by CodeRabbit

  • User Interface Update: Enhanced the network switching experience in the Polkagate extension. Now, when users switch networks, the staking options will automatically be hidden to reduce clutter and potential confusion. This change aims to make the interface cleaner and more intuitive during network transitions.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 26, 2023

Walkthrough

The change introduced in this pull request is straightforward and focused. It modifies the behavior of the _onChangeNetwork function in the account popup of the Polkagate extension. Specifically, it ensures that staking options are hidden whenever the network is changed.

Changes

File Summary
.../popup/account/index.tsx The _onChangeNetwork function now sets showStakingOptions to false, hiding staking options when the network is changed.

🐇

In the land of code, where logic is king,
A small change can make a big swing.
When networks shift in the blink of an eye,
Staking options now wave goodbye. 🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

@Nick-1979 Nick-1979 changed the title Update index.tsx address issue #873 Oct 26, 2023
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ab8f4f1 and 0e78cdd.
Files selected for processing (1)
  • packages/extension-polkagate/src/popup/account/index.tsx (1} hunks)
Files skipped from review due to trivial changes (1)
  • packages/extension-polkagate/src/popup/account/index.tsx

@Nick-1979 Nick-1979 closed this Nov 1, 2023
@Nick-1979 Nick-1979 deleted the issue873 branch November 10, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

close stake option popUp on chain change
1 participant