fix hook dependency issue

PolkaGate · Jul 10, 2024 · a2f2087 · a2f2087
1 parent f118835
commit a2f2087
Showing 1 changed file with 15 additions and 16 deletions.
diff --git a/packages/dapp/src/App.tsx b/packages/dapp/src/App.tsx
@@ -73,10 +73,6 @@ export default function App() {
     ApiPromise.create({ provider: wsProvider }).then(setApi);
   }, [endpoint]);
 
-  useEffect(() => {
-    handleEnable();
-  }, [hasFlaskDetected]);
-
   useEffect(() => {
     /** To get the snap account */
     extensions?.length &&
@@ -98,18 +94,6 @@ export default function App() {
     }
   }, [account, chainName]);
 
-  const handleInstallClick = useCallback(() => {
-    if (hasFlaskDetected === false) {
-      const FLASK_URL = 'https://chromewebstore.google.com/detail/metamask-flask-developmen/ljfoeinjpaedjfecbmggjgodbgkmjkjk';
-
-      window.open(FLASK_URL, '_blank');
-
-      return;
-    }
-
-    handleEnable();
-  }, [hasFlaskDetected]);
-
   const handleEnable = useCallback(() => {
     hasFlaskDetected && web3Enable('snap-only')
       .then((ext: InjectedExtension[] | undefined) => {
@@ -122,6 +106,21 @@ export default function App() {
       });
   }, [hasFlaskDetected]);
 
+  useEffect(() => {
+    hasFlaskDetected && handleEnable();
+  }, [hasFlaskDetected, handleEnable]);
+
+  const handleInstallClick = useCallback(() => {
+    if (hasFlaskDetected === false) {
+      const FLASK_URL = 'https://chromewebstore.google.com/detail/metamask-flask-developmen/ljfoeinjpaedjfecbmggjgodbgkmjkjk';
+
+      window.open(FLASK_URL, '_blank');
+
+      return;
+    }
+
+    handleEnable();
+  }, [hasFlaskDetected , handleEnable]);
 
   useEffect(() => {
     hasFlask().then(setHasFlask)