Refactor: Introduce complexConjugate Message, Deprecate conjugated #231
Conversation
Pharo is then able to put a dot next to the method in production.
src/Math-Complex/PMComplex.class.st
Outdated
| PMComplex >> isReal [ | ||
|
|
||
| ^ imaginary = 0 and: [ real >= 0 ] | ||
| ] |
There was a problem hiding this comment.
Very true. Thus we may have a bug and a missing test.
src/Math-Complex/PMComplex.class.st
Outdated
| "Return the square root of the receiver with a positive imaginary part." | ||
|
|
||
| | u v | | ||
| (imaginary = 0 and: [real >= 0]) | ||
| ifTrue: [^self class real: real sqrt imaginary: 0]. | ||
| self isReal ifTrue: [ ^ self class real: real sqrt imaginary: 0 ]. |
There was a problem hiding this comment.
I think you extract (imaginary = 0 and: [real >= 0]) a bit too fast, this is not replaced by isReal but by isReal and positive.
There was a problem hiding this comment.
How about z isZero or: z isAPositiveReal?
There was a problem hiding this comment.
I don't know if this is necessary. Maybe keep it like it was before.
There was a problem hiding this comment.
Sure. Perhaps we need more tests before refactoring.
There was a problem hiding this comment.
I have inlined the method for us.
| v := (self abs - real / 2) sqrt. | ||
| u := imaginary / 2 / v. | ||
| ^self class real: u imaginary: v | ||
| ^ self class real: u imaginary: v |
There was a problem hiding this comment.
These may be formatting improvements by Pharo when I inlined the isReal method
|
@SergeStinckwich I think we could add more tests for the square root message. I can do that as my next PR. Rather than tests in one method, I would rather write separate test methods with good names. |
Issue no. #192.