Issue 192: Have Number Provide Complex Conjugate Message #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…complex numbers. It may be that we need to normalise the denominator first.
real and imaginary parts are Fractions.
hemalvarambhia
changed the title
hemalvarambhia
commented
Apr 10, 2022
| @@ -750,6 +750,38 @@ PMComplexTest >> testTimesPolynomial [ | |||
| self assert: (poly * c at: 0) equals: c | |||
| ] | |||
|
|
|||
| { #category : #tests } | |||
| PMComplexTest >> testWeCanWriteComplexNumbersWhoRealAndImaginaryPartsAreFractions [ | |||
There was a problem hiding this comment.
Whose Real....
|
Don't merge yet, @SergeStinckwich . I need to correct a selector name. |
hemalvarambhia
commented
Apr 11, 2022
src/Math-Complex/PMComplex.class.st
Outdated
| { #category : #converting } | ||
| PMComplex >> asInteger [ | ||
| ^ self. | ||
| ] |
There was a problem hiding this comment.
This may not make sense, at least I never recall this from my days as a physicist
There was a problem hiding this comment.
I'll remove this, and accept quotients of complex numbers aren't possible yet.
There was a problem hiding this comment.
@SergeStinckwich addressed now. Please review when you have energy and capacity.
…ned method and corrected a programmer test.
hemalvarambhia
commented
Apr 14, 2022
| #category : #'Math-Tests-Complex' | ||
| } | ||
|
|
||
| { #category : #tests } |
There was a problem hiding this comment.
Name these categories better.
hemalvarambhia
commented
Apr 14, 2022
| @@ -750,6 +750,38 @@ PMComplexTest >> testTimesPolynomial [ | |||
| self assert: (poly * c at: 0) equals: c | |||
| ] | |||
|
|
|||
| { #category : #tests } | |||
There was a problem hiding this comment.
'Expressing complex numbers' might be a better name.
SergeStinckwich
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #192
Should Number Respond To ComplexConjugate?