Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where with no filter added no files are selectable on Windows (#211) #224

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

IohannRabeson
Copy link
Contributor

@IohannRabeson IohannRabeson commented Nov 25, 2024

I checked on MacOS and Windows and I got the issue only on Windows.

Copy link
Owner

@PolyMeilex PolyMeilex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "All Files" string will not play nicely with localization, but for now let's pretend that EN is the only language in the world 😄

Thanks!

@PolyMeilex PolyMeilex merged commit 7c99656 into PolyMeilex:master Nov 25, 2024
13 checks passed
@IohannRabeson
Copy link
Contributor Author

IohannRabeson commented Nov 30, 2024

@PolyMeilex would you be interested in a PR for localization? I looked a little bit in the code and I see few other places where strings are hardcoded:

I see there is the crate rust-i18n that looks promising.
I think the difficulty is "how to find the current locale for each backend". -> oh I just found out there is sys-locale
Let me know if you are interested, I will be happy to use my spare time to help.

@PolyMeilex
Copy link
Owner

I would rather not introduce more dependencies and complexity.

  • On Windows everything works out of the box already.
  • On Zenity backend, I would like to use the localization support Zenity already has internally, it just sadly seems to not be exposed to the users atm, even tho needed localization strings are already there.
  • And on MacOS I have no idea, there is probably no build-in localization string for this.

The *Custom labels are supported, so users can always do the localization manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants