Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check connection is open #202

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Check connection is open #202

wants to merge 3 commits into from

Conversation

ikrivosheev
Copy link

Sometimes, i see in logs error: type=<class 'AttributeError'>, error='NoneType' object has no attribute 'drain' after channel.basic_publish. It is vary hard for reproduce.

@RemiCardona
Copy link
Contributor

which version of python are you using? maybe there's been a change in the standard library

@ikrivosheev
Copy link
Author

ikrivosheev commented May 18, 2019

python 3.7. Issue is open in python bag-tracker. Update library to new version - does not help.

@ikrivosheev
Copy link
Author

You are planning to merge?

@dzen
Copy link
Contributor

dzen commented May 28, 2019

Hello @ikrivosheev.

I'm not going to merge this:

  • until we know whats going on, if it's a disconnection handling problem, a specific python version bug
  • until commits does not explain what we're going to fix with a comment (inside the commit or so)
  • until we have some test reproducing the bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants