Modernize project #181
Merged
Modernize project #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandre35
force-pushed
the
sandre/bookworm_support
branch
2 times, most recently
from
be14706 to
d357dba
Compare
sandre35
force-pushed
the
sandre/bookworm_support
branch
from
d357dba to
0b50425
Compare
qbey
reviewed
Feb 22, 2024
CHANGELOG.rst
Outdated
| @@ -4,7 +4,12 @@ ChangeLog | |||
| 8.1 (unreleased) | |||
| ---------------- | |||
|
|
|||
| - Nothing changed yet. | |||
| - Add support for Python 3.12 | |||
| - Drop support for Python 3.11 | |||
There was a problem hiding this comment.
You mean "add support" right?
| install_requires = | ||
| click | ||
| docker>=3.0.0 | ||
| importlib_metadata; python_version<"3.8" |
There was a problem hiding this comment.
The following line can also be removed?
importlib.resources exists in Python 3.7, thus removing backport dependency.
sandre35
force-pushed
the
sandre/bookworm_support
branch
from
0b50425 to
9b9fb9f
Compare
RemiCardona
approved these changes
Feb 23, 2024
src/grocker/builders/op.py
Outdated
| @@ -93,7 +93,7 @@ def get_manifest_digest(name): | |||
| return None # Docker HUB API is not documented | |||
|
|
|||
| registry, repository = registry_repository.split('/', 1) | |||
| response = requests.head(f'https://{registry}/v2/{repository}/manifests/{tag}') | |||
| response = requests.head(f'https://{registry}/v2/{repository}/manifests/{tag}', timeout=60) | |||
There was a problem hiding this comment.
5 seconds should me more than enough, no need to ever wait that long
requirements-dev.txt
Outdated
| @@ -26,3 +26,4 @@ vulture | |||
| # Release | |||
| zest.releaser[recommended] | |||
| polydev.github | |||
There was a problem hiding this comment.
looking at https://github.com/Polyconseil/polydev-github/tree/master, I think we could drop this now that releases are done by GH actions
- Drop flake8-builtins-unleashed plugin. This plugin is not maintained anymore and is not compatible with flake8 > 3.0
sandre35
force-pushed
the
sandre/bookworm_support
branch
from
9b9fb9f to
8a84ea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.