Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixin for checkbox border and radius #185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

grudra7714
Copy link

Added mixins for checkbox container border and radius
Demo

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@grudra7714
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@kompike
Copy link

kompike commented Nov 16, 2017

Fixes #182, fixes #184.

@kompike
Copy link

kompike commented Dec 26, 2017

I'm very interested in changes provided by current PR. I would like to know if there are any timelines or estimates for processing this code, or at the moment I should create custom component with specified functionality for my project?
Thank you in advance!

@jouni
Copy link

jouni commented Jan 3, 2018

If you need a checkbox that you can style freely, try vaadin-checkbox: https://github.com/vaadin/vaadin-checkbox

There’s a material theme available for it as well: https://cdn.vaadin.com/vaadin-material-theme/0.3.0/demo/checkboxes.html

@gerarts
Copy link

gerarts commented Nov 14, 2018

CI failure seems to be an issue with the CI server, not the PR. Can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants