fix: 🐛 Correct assertion on zero asset balance in portfolio #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the latest develop changes on core side, when a asset balance reaches zero in a portfolio, that value is removed from
portfolio.portfolioAssetBalancesstorage. Here is the core change - PolymeshAssociation/Polymesh@a79a4ae#diff-fb1ae7635150b89447e4ab169b054826ada7d83a632fb647bea7f55a323385a7This fixes the assertion where it was expected to get zero balance for the same when querying the portfolio details. Now it just returns empty array of asset balances
Breaking Changes
NA
JIRA Link
Checklist