refactor: 💡 pr comments

.eslintrc

@@ -7,6 +7,7 @@
     "es6": true
   },
   "rules": {
+    "no-console": ["error", { "allow": ["warn", "error"] }],
     "no-useless-constructor": "off",
     "no-use-before-define": "off",
     "@typescript-eslint/explicit-function-return-type": ["warn"],

src/api/procedures/createAsset.ts

@@ -427,7 +427,8 @@ export async function prepareStorage(
   const customTypeData = await prepareStorageForCustomType(
     assetType,
     values(KnownAssetType),
-    context
+    context,
+    'createAsset'
   );
 
   return {

src/api/procedures/createNftCollection.ts

@@ -492,7 +492,12 @@ export async function prepareStorage(
 
   const needsLocalMetadata = collectionKeys.some(isLocalMetadata);
 
-  const customTypeData = await prepareStorageForCustomType(nftType, values(KnownNftType), context);
+  const customTypeData = await prepareStorageForCustomType(
+    nftType,
+    values(KnownNftType),
+    context,
+    'createNftCollection'
+  );
 
   return {
     customTypeData,

src/api/procedures/modifyAsset.ts

@@ -208,8 +208,6 @@ export async function prepareModifyAsset(
       rawType = internalAssetTypeToAssetType(newType as KnownAssetType, context);
     }
 
-    console.log('updating type');
-
     transactions.push(
       checkTxType({
         transaction: tx.asset.updateAssetType,
@@ -275,7 +273,8 @@ export async function prepareStorage(
   const customTypeData = await prepareStorageForCustomType(
     assetType,
     values(KnownAssetType),
-    context
+    context,
+    'modifyAsset'
   );
 
   return { customTypeData };

src/api/procedures/types.ts

@@ -664,6 +664,7 @@ export interface CreateAssetParams {
    * type of security that the Asset represents (e.g. Equity, Debt, Commodity). Common values are included in the
    *   {@link types!KnownAssetType} enum, but custom values can be used as well. Custom values must be registered on-chain the first time
    *   they're used, requiring an additional transaction. They aren't tied to a specific Asset
+   *   if using a custom type, it can be provided as a string (representing name) or a BigNumber (representing the custom type ID)
    */
   assetType: KnownAssetType | string | BigNumber;
   /**

src/utils/internal.ts

@@ -2387,7 +2387,8 @@ export function isV6Spec(specName: string, specVersion: number): boolean {
 export async function prepareStorageForCustomType(
   customType: string | BigNumber,
   knownTypes: string[],
-  context: Context
+  context: Context,
+  method: string
 ): Promise<Storage['customTypeData']> {
   let customTypeData: Storage['customTypeData'];
 
@@ -2398,8 +2399,7 @@ export async function prepareStorageForCustomType(
     if (rawValue.isEmpty) {
       throw new PolymeshError({
         code: ErrorCode.DataUnavailable,
-        message:
-          'createNftCollection was given a custom type ID that does not have an corresponding value',
+        message: `${method} was given a custom type ID that does not have an corresponding value`,
         data: { customType },
       });
     }