Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 allow submitting offline tx with just payload #1438

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

polymath-eric
Copy link
Collaborator

@polymath-eric polymath-eric commented Jan 31, 2025

Description

allow users to pass in only the inner payload in network.submitTransaction

Breaking Changes

None

JIRA Link

DA-1451

Checklist

  • Updated the Readme.md (if required) ?

@polymath-eric polymath-eric requested a review from a team as a code owner January 31, 2025 20:59
@F-OBrien
Copy link
Collaborator

A signed rawPayload should also be accepted for submitting. This gives an example of how the raw can be decoded and prepared for submitting
https://github.com/F-OBrien/example-polymesh-sdk-scripts/blob/1a997889c0f4f94445ac2e9a07e0eb661151b157/src/transactionSigning/RawPayloadSigning.ts#L172

VictorVicente
VictorVicente previously approved these changes Feb 10, 2025
@prashantasdeveloper prashantasdeveloper dismissed stale reviews from VictorVicente and themself via f701e12 February 21, 2025 11:09
polymath-eric and others added 2 commits February 21, 2025 16:39
allow users to pass in only the inner payload in
`network.submitTransaction`
allow users to pass in only the inner raw payload in
`network.submitTransaction`
VictorVicente
VictorVicente previously approved these changes Feb 24, 2025
F-OBrien
F-OBrien previously approved these changes Feb 25, 2025
Copy link
Collaborator

@F-OBrien F-OBrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor comments code comments

@prashantasdeveloper
Copy link
Collaborator

/fast-forward

@prashantasdeveloper prashantasdeveloper merged commit d305da0 into alpha Feb 26, 2025
12 checks passed
@prashantasdeveloper prashantasdeveloper deleted the submit-offline-tx branch February 26, 2025 15:30
@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version 27.4.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants