-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic creation/updating of metadata in .raph for MetaGraph #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianmurariu
requested changes
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good overall, just one comment on StaticGraphViewOps
e201a9d
to
5fd1915
Compare
fabianmurariu
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add functions hooking into graph creation and graph writes to create/update metadata within the .raph file, which can then be fetched from the MetaGraph resource from GraphQL.
This metadata currently consists of:
Why are the changes needed?
To provide an endpoint to fetch this information without having to decode and fetch the full graph.
Does this PR introduce any user-facing change? If yes is this documented?
A new endpoint is provided from GQL, and the new behavior will modify the .raph file, but should not be a breaking change for users.
How was this patch tested?
Tests added to raphtory-graphql to test that the metadata is created/updated and can be fetched via MetaGraph (as well as namespaces in general), and also tests were added to check that the right behavior happens if an invalid .raph file exists.
Are there any further changes required?
None unless more complex metadata is required in the future, or a more complex storage method is needed.