fix: Fix candidate race issue on visible property

PopStackHack · Nov 3, 2020 · c102274 · c102274
1 parent 6f74fd9
commit c102274
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 10 deletions.
diff --git a/...tack/mvoter2015/feature/candidate/listing/lowerhouse/LowerHouseCandidateListController.kt b/...tack/mvoter2015/feature/candidate/listing/lowerhouse/LowerHouseCandidateListController.kt
@@ -68,12 +68,7 @@ class LowerHouseCandidateListController : MvvmController<ControllerLowerHouseCan
     }
 
     if (viewModel.viewItemLiveData.value == null) {
-      lifecycleScope.launch {
-        //For some reason on fast phone, the candidate list doesn't show up
-        //Adding delay somehow solves this problem
-        delay(100)
         loadCandidates()
-      }
     }
   }
 
@@ -91,7 +86,6 @@ class LowerHouseCandidateListController : MvvmController<ControllerLowerHouseCan
 
   private fun observeViewItem(viewState: AsyncViewState<CandidateListResult>) = with(binding) {
     progressBar.isVisible = viewState is AsyncViewState.Loading
-    rvCandidate.isVisible = viewState is AsyncViewState.Success
     tvErrorMessage.isVisible = viewState is AsyncViewState.Error
     btnRetry.isVisible = viewState is AsyncViewState.Error
 

diff --git a/...voter2015/feature/candidate/listing/regionalhouse/RegionalHouseCandidateListController.kt b/...voter2015/feature/candidate/listing/regionalhouse/RegionalHouseCandidateListController.kt
@@ -85,7 +85,6 @@ class RegionalHouseCandidateListController() : MvvmController<ControllerRegional
 
   private fun observeViewItem(viewState: AsyncViewState<CandidateListResult>) = with(binding) {
     progressBar.isVisible = viewState is AsyncViewState.Loading
-    rvCandidate.isVisible = viewState is AsyncViewState.Success
     tvErrorMessage.isVisible = viewState is AsyncViewState.Error
     btnRetry.isVisible = viewState is AsyncViewState.Error
     groupRemark.isVisible = false

diff --git a/...tack/mvoter2015/feature/candidate/listing/upperhouse/UpperHouseCandidateListController.kt b/...tack/mvoter2015/feature/candidate/listing/upperhouse/UpperHouseCandidateListController.kt
@@ -82,7 +82,6 @@ class UpperHouseCandidateListController : MvvmController<ControllerUpperHouseCan
 
   private fun observeViewItem(viewState: AsyncViewState<CandidateListResult>) = with(binding) {
     progressBar.isVisible = viewState is AsyncViewState.Loading
-    rvCandidate.isVisible = viewState is AsyncViewState.Success
     tvErrorMessage.isVisible = viewState is AsyncViewState.Error
     btnRetry.isVisible = viewState is AsyncViewState.Error
 

diff --git a/buildSrc/src/main/kotlin/Dependencies.kt b/buildSrc/src/main/kotlin/Dependencies.kt
@@ -5,7 +5,7 @@ object BuildConfig {
 
   private const val versionMajor = 4
   private const val versionMinor = 1
-  private const val versionPatch = 4
+  private const val versionPatch = 5
   private const val versionBuild = 0
 
   const val versionName =

diff --git a/release.properties b/release.properties
@@ -1,2 +1,2 @@
-forceUpdate=false
+forceUpdate=true
 url=https://us-central1-maepaysoh2020.cloudfunctions.net/deploy/android