Introduce a failing test for dotless domain #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ICANN has prohibited dotless domain names: https://www.icann.org/news/announcement-2013-08-30-en While these are technically possible in the spec, they have effectively been made invalid. email-validate will accept these domains in its current form, when it should mark them as invalid.
|
That ICANN announcement only applies to new domain names. The existing dotless names continue to be valid. Like http://ai./ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source Issue
#52
Issue
ICANN has prohibited dotless domain names:
https://www.icann.org/news/announcement-2013-08-30-en
While these are technically possible in the spec, they have effectively
been made invalid. email-validate will accept these domains in its
current form, when it should mark them as invalid.
Description
This PR introduces a failing test.