This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
feat: accept other JSON types as distinct_id, stringify them #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
posthog-js accepts any JSON value as
distinct_id
and capture-py just stringifies them before truncating to 200 chars.null
as a value, but that feels far-fetched as the value is required for the event to be valid. I'll go with the breaking change in that PR, and check ClickHouse to see how many teams would be impacted.