Skip to content
This repository has been archived by the owner on Jun 21, 2024. It is now read-only.

Temporarily switch to a single build-args argument #10

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

bretthoerner
Copy link
Contributor

@bretthoerner bretthoerner commented Feb 7, 2024

The way I had it is definitely the way it works in github/build-push-action, but I guess depot doesn't support this?

I verified in the Depot run that it is putting both args into the same --build-args (which is not what we want):

2024-02-07T15:30:23.6497484Z [command]/opt/hostedtoolcache/depot/2.53.0/arm64/depot build --build-arg RUST_BACKTRACE=1 BIN=hook-worker --cache-from ...

I'll have to bring it up with their support. For now, I'd like to get the build working.

(Additionally, RUST_BACKTRACE=1 came from the capture repo, and it's an argument to the build. Was rustc crashing for capture at some point? Either way, it doesn't seem strictly necessary to have in there this very second, so that I can get unblocked here.)

@bretthoerner bretthoerner requested a review from a team February 7, 2024 16:42
Copy link
Contributor

@xvello xvello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I don't recall why we'd need this for capture. Suspected it was to enable continuous profiling but, that another field in Cargo.toml (that I need to remove btw)
image

@bretthoerner bretthoerner merged commit 6770bed into main Feb 7, 2024
4 checks passed
@bretthoerner bretthoerner deleted the brett/single-build-arg branch February 7, 2024 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants