-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get all feature flags related to a distinct_id (4/4) #57
Draft
miguelhrocha
wants to merge
13
commits into
PostHog:main
Choose a base branch
from
miguelhrocha:get-all-feature-flags-from-user
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: get all feature flags related to a distinct_id (4/4) #57
miguelhrocha
wants to merge
13
commits into
PostHog:main
from
miguelhrocha:get-all-feature-flags-from-user
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelhrocha
changed the title
Get all feature flags from user
Get all feature flags from user (1/4)
Jun 2, 2024
miguelhrocha
changed the title
Get all feature flags from user (1/4)
Get all feature flags from user (4/4)
Jun 2, 2024
miguelhrocha
changed the title
Get all feature flags from user (4/4)
feat: get all feature flags related to a distinct_id
Jun 2, 2024
miguelhrocha
changed the title
feat: get all feature flags related to a distinct_id
feat: get all feature flags related to a distinct_id (4/4)
Jun 2, 2024
This was referenced Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 4th part of the feature flag support for the Java SDK. This PR should be reviewed in order after:
Please abstain of reviewing until the dependencies are merged, and this pull request is rebased.
Reviewer notes
This change brings the Java SDK closer to feature parity with other server-based SDKs related to feature flags. Now, the consumers of this library will be able to:
distinct_id
.