Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change Application opened to application became active for native events #211

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Mar 25, 2024

Problem

Closes #144
https://posthoghelp.zendesk.com/agent/tickets/11961
Depend on the SDK config, the dashboard should use different event names, its better to align that within the SDK

Changes

Technically a breaking change but I don't see many people using captureNativeAppLifecycleEvents anyways, it's written in the changelog.
It's hard for support to figure out the multiple scenarios depending on the SDK configuration.
Our mobile dashboard templates don't even consider the from_background property anyway, so now using this config (captureNativeAppLifecycleEvents) will match our templates.
Added the app version and build to the other integrations.

Release info Sub-libraries affected

Bump level

  • Major
  • Minor
  • Patch

Libraries affected

  • All of them
  • posthog-web
  • posthog-node
  • posthog-react-native

Changelog notes

  • Added support for X

Copy link

github-actions bot commented Mar 25, 2024

Size Change: 0 B

Total Size: 72.8 kB

ℹ️ View Unchanged
Filename Size
posthog-node/lib/index.cjs.js 19.7 kB
posthog-node/lib/index.esm.js 19.7 kB
posthog-web/lib/index.cjs.js 16.7 kB
posthog-web/lib/index.esm.js 16.7 kB

compressed-size-action

@marandaneto marandaneto changed the title chore; Change Application opened to application became active for native events chore: Change Application opened to application became active for native events Mar 25, 2024
@marandaneto marandaneto requested review from benjackwhite and a team March 25, 2024 09:12
@marandaneto marandaneto marked this pull request as ready for review March 25, 2024 09:12
@marandaneto marandaneto merged commit b59a975 into main Mar 26, 2024
4 checks passed
@marandaneto marandaneto deleted the chore/app-became-active-native-app branch March 26, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application Became Active event on RN should have been Application Opened with from_background=true property
2 participants