Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework destinations intro documentation #9894

Merged
merged 35 commits into from
Nov 15, 2024
Merged

Conversation

daniloc
Copy link
Contributor

@daniloc daniloc commented Nov 14, 2024

Changes

Our description of destinations gets immediately into the weeds, failing to quickly convey the power of what we're offering. More than that, it doesn't help a new user set up a new templated destination, the most common use case.

Addresses #9866, #9865, and #9885 by rewriting the destinations intro and adding a reworked advanced usage guide based on the original destination docs.

Screenshot 2024-11-14 at 1 48 36 PM

Checklist

  • Words are spelled using American English
  • Titles are in sentence case
  • Feature names are in sentence case too
  • Use relative URLs for internal links

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Nov 15, 2024 6:31pm

@daniloc daniloc changed the title Rework destinations intro Rework destinations intro documentation Nov 14, 2024
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this feels way better just some small tweaks needed

contents/docs/cdp/destinations/index.md Outdated Show resolved Hide resolved
contents/docs/cdp/advanced.md Outdated Show resolved Hide resolved
contents/docs/cdp/advanced.md Outdated Show resolved Hide resolved
contents/docs/cdp/advanced.md Outdated Show resolved Hide resolved
contents/docs/cdp/advanced.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ivanagas ivanagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some final tweaks

contents/docs/cdp/destinations/advanced.md Outdated Show resolved Hide resolved
contents/docs/cdp/destinations/advanced.md Outdated Show resolved Hide resolved
contents/docs/cdp/destinations/advanced.md Outdated Show resolved Hide resolved
contents/docs/cdp/destinations/advanced.md Outdated Show resolved Hide resolved
contents/docs/cdp/destinations/advanced.md Outdated Show resolved Hide resolved
contents/docs/cdp/destinations/index.md Outdated Show resolved Hide resolved

[Learn more about this in advanced usage](/docs/cdp/advanced).

## Caveats
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think this should go in the FAQ

Copy link
Contributor Author

@daniloc daniloc Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I debated that in my mind quite a bit as well, here is my argument for keeping it here:

I think these are more gotchas than they are FAQs, so I want to be upfront instead of burying them. If someone trips up based on one of these issues, I don't want them to assume that the feature is broken and give up on it.

contents/docs/cdp/destinations/index.md Outdated Show resolved Hide resolved
contents/docs/cdp/destinations/index.md Outdated Show resolved Hide resolved
contents/docs/cdp/destinations/advanced.md Outdated Show resolved Hide resolved
@daniloc
Copy link
Contributor Author

daniloc commented Nov 14, 2024

Thanks for the thorough eye, gang. I think we're in a good spot but @oliverb123 you've been instrumental here so I'll leave it open in case there's anything to add when you swing through in the morning.

Copy link
Contributor

@bijanbwb bijanbwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

```
{event.event} was triggered by {person.properties.first_name} {person.properties.last_name}

// Outputs: $pageview was triggered by Max the Hedgehog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. It's a great example. 👏


For most cases, we recommend using one of the templates. These take care of most logic under the hood, exposing simple inputs for you to configure.

You can, however, modify any destination by clicking `show source code`. From here you can modify the inputs – for example marking an input as secret so that it is encrypted as rest – or changing the implementation of the destination itself.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we use bold for buttons, so maybe this should be **show source code** (instead of using backticks)?

I might be looking at the wrong part of the interface but is the button text actually "Edit source code"?

contents/docs/cdp/destinations/customizing-destinations.md Outdated Show resolved Hide resolved

## Testing

The hardest part of integrating two services is making sure everything works as you expect. Every destination includes a built-in testing interface, enabling you to send real data from PostHog on-demand to your target service and debug any errors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. ❤️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly. The DX for destinations is just fucking EXQUISITE, as good as it gets.

contents/docs/cdp/destinations/index.md Outdated Show resolved Hide resolved
contents/docs/cdp/destinations/index.md Outdated Show resolved Hide resolved
@daniloc daniloc merged commit 5719412 into master Nov 15, 2024
3 checks passed
@daniloc daniloc deleted the rewrite-cdp-destination-intro branch November 15, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants