feat(capture): handle empty string UUIDs for /batch
endpoint
#24586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We tried to make a change to the Go SDK to support passing in client-defined UUIDs to the
/batch
endpoint, but sometimes those UUIDs were empty strings. This led to the SDK breaking because, while our batch endpoint supports passing in UUIDs, it doesn't handle the empty string case. Obviously, we should tell our users to omit UUIDs that are empty, but I think updating our serializer to ignore them is probably a good idea, too.Changes
Update the
RawEvent
serializer to treat empty strings in the UUID field asNone
.Does this work well for both Cloud and self-hosted?
Yup.
How did you test this code?
Wrote some tests; maybe overkill, but still seems handy since this is a non-standard deserialization path. Here's a rust playground that shows the fix, too: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=648f9a409cd5c89fdbc4b05c786d5b3a