fix: support branching in survey preview submit #27623
Draft
+306
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasheriques
force-pushed
the
fix/survey-previews-supports-branching
branch
from
4cdf5d5 to
1b63b77
Compare
lucasheriques
changed the title
lucasheriques
force-pushed
the
fix/survey-previews-supports-branching
branch
from
1b63b77 to
9efaf48
Compare
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
marandaneto
reviewed
Jan 17, 2025
| onPreviewSubmit={() => handleSetSelectedPageIndex(previewPageIndex + 1)} | ||
| onPreviewSubmit={(response) => { | ||
| handleSetSelectedPageIndex( | ||
| getNextQuestionIndex( |
There was a problem hiding this comment.
Since the JS SDK is responsible for rendering the preview and the SDK already knows whats the next question, would be possible to let the JS SDK handle this altogether?
marandaneto
reviewed
Jan 17, 2025
| } | ||
| } | ||
|
|
||
| export function getNextQuestionIndex( |
There was a problem hiding this comment.
not sure if this is a copy-pasta from the JS SDK, but if not, you could inspire from in case something isn't working well.
marandaneto
changed the title
|
Changed the PR title from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
when previewing surveys, we shouldn't just go to the next question when pressing submit.
instead, use the users' defined logic on branching.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
No impact
How did you test this code?
Tested the feature on localhost
Unit tests