fix: no need to duplicate taxonomy #27657
Draft
+156
−1,598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmmmm, the tests don't like this :/ |
📸 UI snapshots have been updated213 snapshot changes in total. 0 added, 213 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have taxonomy.tsx in FE and taxonomy.py in the backend
some features rely on them being kept in sync - e.g. searching by human readable names...
let's not duplicate them, and then we don't have to keep them in sync
there may be a neater way of not duplicating them... but this at least stops them getting out of sync while someone thinks of it
tested by checking taxonomic filter still works