fix: jwt cache is not purged #3801
Open
+102
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the JWT cache not purging expired tokens in cache. This is tested by adding a new metric pgrst_jwt_cache_size.
| # the cache should now have three tokens | ||
| response = postgrest.admin.get("/metrics") | ||
| assert response.status_code == 200 | ||
| assert "pgrst_jwt_cache_size 3.0" in response.text |
There was a problem hiding this comment.
@taimoorzaeem Is it possible to have the size measured on bytes?
There was a problem hiding this comment.
Maybe. There is no built-in function for this in Data.Cache. I have tried using https://hackage.haskell.org/package/ghc-datasize to calculate size in bytes at runtime, but I have run into problems with that too.
We can try manually writing some logic to calculate the size in bytes, but I guess that would require some effort.
mkleczek
reviewed
Nov 24, 2024
| checkCache <- C.lookup (getJwtCache appState) token | ||
|
|
||
| -- Call first to delete the expired JWTs | ||
| C.purgeExpired jwtCache |
There was a problem hiding this comment.
I am wondering if it is a good idea to add this in the hot path of request processing, unless we are sure it is a constant time operation (and fast).
Otherwise it should be moved to a separate thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3788.
Fixed the JWT cache not purging expired tokens in cache. This is tested by adding a new metric
pgrst_jwt_cache_size.@steve-chavez I can also divide this into two commits, one for adding the new metric and the other for bug fix. Please review and let me know.