Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Grant unidirectional HTTP/3 streams for DoH3 #13678

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jan 8, 2024

Short description

While unidirectional streams are not needed for DNS over QUIC, they are required by the HTTP/3 RFC and thus needed for DNS over HTTP/3. This change makes curl and Firefix happy with dnsdist's DoH3 implementation.

Many thanks to hawk on IRC for bringing it up!

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

While unidirectional streams are not needed for DNS over QUIC, they
are required by the HTTP/3 RFC and thus needed for DNS over HTTP/3.
This change makes curl and Firefix happy with dnsdist's DoH3
implementation.
@rgacogne rgacogne added this to the dnsdist-1.9 milestone Jan 8, 2024
@rgacogne rgacogne requested a review from chbruyand January 8, 2024 16:06
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7450026464

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 57.69%

Totals Coverage Status
Change from base Build 7448235306: 0.009%
Covered Lines: 107732
Relevant Lines: 155397

💛 - Coveralls

@hlindqvist
Copy link
Contributor

Excellent, this does indeed seem to fix the problem!

@rgacogne
Copy link
Member Author

rgacogne commented Jan 8, 2024

Thanks for testing and reporting back!

@rgacogne rgacogne merged commit 0f120f7 into PowerDNS:master Jan 8, 2024
75 checks passed
@rgacogne rgacogne deleted the ddist-doh3-uni-streams branch January 8, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants